gru/lstm: Fix missing/incorrect variables and options use#655
Merged
huningxin merged 1 commit intowebmachinelearning:mainfrom Apr 24, 2024
inexorabletash:bugfix-lstm-gru-variables
Merged
gru/lstm: Fix missing/incorrect variables and options use#655huningxin merged 1 commit intowebmachinelearning:mainfrom inexorabletash:bugfix-lstm-gru-variables
huningxin merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:bugfix-lstm-gru-variables
Conversation
- In gru(), batchSize and numDirections were used without being defined. Define them. - In lstm(), numDirections was initialized to 2 if the direction was "backward", should be 1. - In gru() and gruCell(), options.activations was unconditionally added to the operator. Make this conditional. - In lstm() and lstmCell(), options.activations were not added to the operator. Add if given.
Contributor
Author
|
Straightforward fixes noticed while working on other PRs. Please take a look? |
Contributor
Author
|
@huningxin - can you review and merge if it looks good? Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Apr 24, 2024
SHA: 0df0296 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In gru(), batchSize and numDirections were used without being defined. Define them.
In lstm(), numDirections was initialized to 2 if the direction was "backward", should be 1.
In gru() and gruCell(), options.activations was unconditionally added to the operator. Make this conditional.
In lstm() and lstmCell(), options.activations were not added to the operator. Add if given.
Preview | Diff