Skip to content

Comments

Remove softplus() steepness option#651

Merged
huningxin merged 1 commit intowebmachinelearning:mainfrom
a-sully:remove-softplus-steepness
Apr 24, 2024
Merged

Remove softplus() steepness option#651
huningxin merged 1 commit intowebmachinelearning:mainfrom
a-sully:remove-softplus-steepness

Conversation

@a-sully
Copy link
Contributor

@a-sully a-sully commented Apr 22, 2024

Fixes #645


Preview | Diff

@a-sully
Copy link
Contributor Author

a-sully commented Apr 22, 2024

@fdwr PTAL?

@fdwr
Copy link
Collaborator

fdwr commented Apr 23, 2024

FYI @BruceDai since this affects conformance.
FYI @Honry, but I didn't see this impacts the ORT WebNN EP since you just pass default options anyway.

@Honry
Copy link
Contributor

Honry commented Apr 23, 2024

FYI @Honry, but I didn't see this impacts the ORT WebNN EP since you just pass default options anyway.

Correct, we didn't use steepness option in WebNN EP.

@BruceDai
Copy link
Contributor

OK, I will update WPT softplus tests to align with this change. Thanks for your kindly reminder 👍 @fdwr

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 No pushback from my colleagues Chai or Rafael either.

@huningxin huningxin merged commit 2d06961 into webmachinelearning:main Apr 24, 2024
github-actions bot added a commit that referenced this pull request Apr 24, 2024
SHA: 2d06961
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@huningxin
Copy link
Contributor

/cc @shiyi9801

@a-sully a-sully deleted the remove-softplus-steepness branch April 24, 2024 15:06
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 26, 2024
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 26, 2024
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 28, 2024
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293444}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 28, 2024
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293444}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 28, 2024
Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293444}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 30, 2024
…ss, a=testonly

Automatic update from web-platform-tests
webnn: remove softplus parameter steepness

Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293444}

--

wpt-commits: 78709a81cc84279686438385b38572dd3ff44860
wpt-pr: 45899
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Apr 30, 2024
…ss, a=testonly

Automatic update from web-platform-tests
webnn: remove softplus parameter steepness

Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293444}

--

wpt-commits: 78709a81cc84279686438385b38572dd3ff44860
wpt-pr: 45899
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
…ss, a=testonly

Automatic update from web-platform-tests
webnn: remove softplus parameter steepness

Remove this parameter since it's no longer in the spec.

webmachinelearning/webnn#651

Bug: 40206287
Change-Id: Ibcf4b3a7bcda8fc5ba3588667449d46a690b65c3
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5486742
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1293444}

--

wpt-commits: 78709a81cc84279686438385b38572dd3ff44860
wpt-pr: 45899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing steepness parameter of softplus

5 participants