Swap parameters of scalar constant() operand method#650
Swap parameters of scalar constant() operand method#650fdwr merged 25 commits intowebmachinelearning:mainfrom inexorabletash:constant-arg-order
Conversation
Make MLGraphBuilder's constant() operand-vending methods consistent and take the data type as the first parameter. This implicitly makes the type required instead of optional. Use of constant() in decompositions are updated as well, and now use "input" consistently instead of "x" sometimes. Fixes #475
|
FYI, I ran |
|
I'm going to drop this to "draft" to take it off people's radar. This would be a breaking change for lots of content, so we'll want to approach it carefully. |
|
I didn't realize until last week that Chromium didn't implement the scalar version of constant(), so this should be safe to change - no content should be relying on it, right? |
|
@huningxin & @fdwr - please take a look? |
huningxin
left a comment
huningxin
left a comment
There was a problem hiding this comment.
You may also want to update the code sample of explainer https://github.com/webmachinelearning/webnn/blob/main/explainer.md?plain=1#L38
Done in 1d9fb59 |
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Thanks JB. Small suggestions for your consideration.
|
All suggestions moot because addressed elsewhere. So merging... |
SHA: 91e2407 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I realized too late that the updated decompositions all use |
4 participants
Make MLGraphBuilder's constant() operand-vending methods consistent and take the data type as the first parameter. This implicitly makes the type required instead of optional.
Use of constant() in decompositions are updated as well, and now use "input" consistently instead of "x" sometimes.
Fixes #475
Preview | Diff