Editorial: Add note about keepDimensions of reduction ops#648
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Apr 19, 2024
inexorabletash:impl-note-keepdimensions
Merged
Editorial: Add note about keepDimensions of reduction ops#648fdwr merged 1 commit intowebmachinelearning:mainfrom inexorabletash:impl-note-keepdimensions
fdwr merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:impl-note-keepdimensions
Conversation
Contributor
Author
|
@fdwr can you take a look, since I based this on your comment? Thanks! |
Collaborator
|
FYI @lisa0314 @huningxin. |
github-actions bot
added a commit
that referenced
this pull request
Apr 19, 2024
SHA: 50fbb92 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note based on @fdwr's comment: if the backend doesn't support a keepDimensions option, the implementation can insert a no-op reshape to keep or drop the reduced dimension(s) as needed.
Fixes #465
Preview | Diff