Bug fix: Drop "... have been checked..." notes#620
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Mar 27, 2024
inexorabletash:bugfix-drop-validity-notes
Merged
Bug fix: Drop "... have been checked..." notes#620fdwr merged 1 commit intowebmachinelearning:mainfrom inexorabletash:bugfix-drop-validity-notes
fdwr merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:bugfix-drop-validity-notes
Conversation
A smattering of methods on MLGraphBuilder (build, buildSync, concat, constant, expand, and input) had a note about permissions and context validity at the start of the steps. This is implicit, and applies to all methods so it was confusing - was there something special about these methods? Nope. So remove the notes. Fixes #501
Contributor
Author
|
Easy one - @fdwr and @huningxin - please review/merge at your leisure. |
Collaborator
|
Looks good! |
Collaborator
Red is a nice color 😉. TY, merging. |
fdwr
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A smattering of methods on MLGraphBuilder (build, buildSync, concat, constant, expand, and input) had a note about permissions and context validity at the start of the steps. This is implicit, and applies to all methods so it was confusing - was there something special about these methods?
Nope. So remove the notes.
Fixes #501
Preview | Diff