Skip to content

Comments

Remove MLAutoPad#587

Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom
huningxin:remove_auto_pad
Feb 27, 2024
Merged

Remove MLAutoPad#587
fdwr merged 1 commit intowebmachinelearning:mainfrom
huningxin:remove_auto_pad

Conversation

@huningxin
Copy link
Contributor

@huningxin huningxin commented Feb 27, 2024

Fix #326


Preview | Diff

Copy link
Contributor

@inexorabletash inexorabletash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ningxin.

@fdwr fdwr merged commit f269174 into webmachinelearning:main Feb 27, 2024
github-actions bot added a commit that referenced this pull request Feb 27, 2024
SHA: f269174
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable pushed a commit to chromium/chromium that referenced this pull request Mar 8, 2024
This CL removes the MLAutoPad enum and its usages for conv2d,
convTranspose2d and pool2d operators according to WebNN spec change [1].
The WPT already removed the test cases for MLAutoPad [2], so there are
no changes of WPT and baseline in this CL.

[1]: webmachinelearning/webnn#587
[2]: web-platform-tests/wpt#44823

Bug: 40206287,327499424
Change-Id: I5df94d3ecc95a597286bb5633a8c3fa2a563b02c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5338716
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: ningxin hu <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1269941}
huningxin added a commit to huningxin/webnn-samples that referenced this pull request Mar 8, 2024
huningxin added a commit to huningxin/webnn-samples that referenced this pull request Mar 8, 2024
Honry pushed a commit to webmachinelearning/webnn-samples that referenced this pull request Mar 8, 2024
Honry pushed a commit to Honry/webnn-samples that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define the algorithm of calculating the effective padding for "same-upper" and "same-lower" option

3 participants