Skip to content

Comments

Bug fix: Validate MLGraph's context in MLContext's compute()#584

Merged
anssiko merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:bugfix-validate-compute-context
Feb 27, 2024
Merged

Bug fix: Validate MLGraph's context in MLContext's compute()#584
anssiko merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:bugfix-validate-compute-context

Conversation

@inexorabletash
Copy link
Contributor

@inexorabletash inexorabletash commented Feb 26, 2024

This matches the Chromium prototype implementation.

Fixes #341


Preview | Diff

This matches the Chromium prototype implementation.

Fixes #341
@anssiko anssiko requested a review from fdwr February 26, 2024 17:04
@fdwr
Copy link
Collaborator

fdwr commented Feb 27, 2024

@inexorabletash, Thanks.
@huningxin, appears we can close 341 with this.

@anssiko anssiko merged commit a904425 into webmachinelearning:main Feb 27, 2024
github-actions bot added a commit that referenced this pull request Feb 27, 2024
SHA: a904425
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@anssiko
Copy link
Member

anssiko commented Feb 27, 2024

@huningxin this seemed to be straight-forward, so I handled this merge for you.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@inexorabletash inexorabletash deleted the bugfix-validate-compute-context branch February 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should validate MLGraph.[[context]] in MLContext.compute() and MLContext.computeSync() steps

4 participants