Merged
Conversation
Follow-up to webmachinelearning#553 Fixes webmachinelearning#560
Contributor
Author
|
Thanks for the review, @huningxin. @wchao1115 if this PR LGTY please feel free to merge at your convenience. Thanks! |
Contributor
|
It looks good to me. @fdwr , do you have any further comments? |
fdwr
approved these changes
Feb 22, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 22, 2024
SHA: b54884c Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 23, 2024
The corresponding spec change was made here: webmachinelearning/webnn#569 Bug: 40206287 Change-Id: I2cc31da2da871f740e8403f2333d60fa5e3a9615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5279557 Reviewed-by: ningxin hu <[email protected]> Commit-Queue: ningxin hu <[email protected]> Auto-Submit: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1264381}
Member
|
FTR: also the corresponding Model Loader API spec changes have been landed: webmachinelearning/model-loader#43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #560
Follow-up to #553
To be coordinated with corresponding changes to the Model Loader API spec: webmachinelearning/model-loader#43
Preview | Diff