WiP: Improve graph execution steps#319
Closed
zolkis wants to merge 0 commit intowebmachinelearning:mainfrom
Closed
WiP: Improve graph execution steps#319zolkis wants to merge 0 commit intowebmachinelearning:mainfrom
zolkis wants to merge 0 commit intowebmachinelearning:mainfrom
Conversation
zolkis
commented
Dec 20, 2022
zolkis
commented
Dec 20, 2022
zolkis
commented
Dec 20, 2022
zolkis
commented
Dec 20, 2022
zolkis
commented
Dec 20, 2022
zolkis
commented
Dec 20, 2022
index.bs
Outdated
| 1. Let |outputDesc| be |graph|.{{MLGraph/[[outputDescriptors]]}}[|key|]. | ||
| 1. If the data type of |outputTensor| elements doesn't match the [=element type=] of {{ArrayBufferView}} |value|, then throw a "{{DataError}}" {{DOMException}} and stop. | ||
| 1. If the byte length of |outputTensor| is not equal to |value|.\[[ByteLength]] and the [=byte length=] of |outputDesc|, then throw a "{{DataError}}" {{DOMException}} and stop. | ||
| 1. Otherwise, set the values of |value| to the values of |outputTensor|. |
Collaborator
Author
There was a problem hiding this comment.
Possibly improve the prose here for assigning vector elements from another vector.
Is this meant to be a copy, or can it be assignment?
zolkis
force-pushed
the
improve-sync-async-execution
branch
from
40ab26e to
e17565e
Compare
Collaborator
Author
|
(Reason for forced push: mistyped the fixed issue number). |
zolkis
force-pushed
the
improve-sync-async-execution
branch
from
e17565e to
071498b
Compare
Member
Member
zolkis
force-pushed
the
improve-sync-async-execution
branch
from
071498b to
019a1f6
Compare
Collaborator
Author
|
Needed to rework it completely, closed this and continued in #329. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out graph resource validation.
Define generic graph execution steps and use them in the sync and async compute() methods.
Address #316.
@huningxin @wchao1115 @anssiko this requires not only a review, but possibly development.
Prose detailing implementation internals has been thin ice in specifications. We need to be generic and flexible to internal optimizations, yet express the intents clearly enough. Your help is needed, please.
Preview | Diff