Add Permissions Policy Integration and initial createContext() hooks#159
Merged
Add Permissions Policy Integration and initial createContext() hooks#159
Conversation
wchao1115
approved these changes
Apr 8, 2021
Member
Author
|
@wchao1115 feel free to merge this PR if it helps unblock your other work. You can also stack your PR on top of this, but I believe in that case we'd need to start merging "from the top" i.e. the latest opened PR to avoid merge conflicts. I'll let you own this workflow with @huningxin so feel free to pick a workflow that works for both of you editors :-) |
Member
Author
|
@wchao1115 @huningxin per discussion today's call, feel free to merge this. I'll let you do the merge to coordinate with other open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #145
In addition to Permissions Policy Integration (per integration best practices), this also adds initial steps for
createContext()to allow integration of the "allowed to use" check.@wchao1115 you wanted to clarify the context creation prose so if this looks good to you you can base your further work on top of this and augment the steps with more context creation details.
Preview | Diff