Skip to content

Comments

Added extended attributes to Web IDL definition#101

Closed
wonsuk73 wants to merge 2 commits intowebmachinelearning:masterfrom
wonsuk73:master
Closed

Added extended attributes to Web IDL definition#101
wonsuk73 wants to merge 2 commits intowebmachinelearning:masterfrom
wonsuk73:master

Conversation

@wonsuk73
Copy link
Contributor

@wonsuk73 wonsuk73 commented Oct 11, 2020

  • Web NN API is to access the hardware acceleration for machine learning. So it is only need to be exposed in secure contexts. It means that this API is only available over HTTPS.
  • removed "Models" from biblio because it isn't unused any more

Preview | Diff

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extended attributes look good to me. Thanks @wonsuk73 !

This was referenced Oct 12, 2020
- Web NN API is to access the hardware acceleration for machine learning. So it is only need to be exposed in secure contexts. It means that this API is only available over HTTPS.
- removed "Models" from biblio because it isn't unused any more
@wchao1115 wchao1115 self-requested a review October 25, 2020 18:05
@wonsuk73
Copy link
Contributor Author

@huningxin This PR is conflict again. So could you give a guide for this? I might need to do the same work I did before. right?

@huningxin
Copy link
Contributor

@huningxin This PR is conflict again. So could you give a guide for this? I might need to do the same work I did before. right?

Please resolve the conflicts as you did before. It would be easier. Since #113 implements a deploy script that will generate the index.html, you can simply drop your changes of index.html.

@wonsuk73
Copy link
Contributor Author

@huningxin, there is errors as below. It might be occurred because of the change of branches. So I would like to withdraw this PR and make a new PR.
error: src refspec — does not match any
error: src refspec force does not match any

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants