Repository navigation
Add ToolActivatedEvent and ToolCancelEvent interfaces - #146
Closed
beaufortfrancois wants to merge 4 commits into
Closed
beaufortfrancois wants to merge 4 commits into
beaufortfrancois wants to merge 4 commits into
Conversation
beaufortfrancois
marked this pull request as draft
March 19, 2026 08:44
bwalderman
requested changes
Mar 19, 2026
| }; | ||
|
|
||
| dictionary ToolCancelEventInit : EventInit { | ||
| DOMString toolName = ""; |
Collaborator
There was a problem hiding this comment.
Looking at this interface, I'm seeing a potential problem with multiple agents and concurrent activations of the same tool. Which one should be cancelled if all we know is the tool name? I'll comment on the issue.
Collaborator
Author
|
@domfarolino Now that #164 has been merged, I guess another one will follow so that I can plug this PR to tool execution. Is that right? |
Collaborator
Author
|
FYI I've rebased this PR because of conflicts |
beaufortfrancois
force-pushed
the
events
branch
from
August 6, 2026 09:32
9f30276 to
7dbb2aa
Compare
Collaborator
|
It looks like this closed mistakenly, since it was based off of the |
Collaborator
Author
|
Gotcha. Here's #245 |
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Sep 27, 2026
This is part of a transition to standardized event attributes; ontoolcancel will follow shortly, eventually replacing WebMCPEvents. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: Iffce26011963e6e501a7843e72a6ea4f6bea0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7642055 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705649}
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Sep 27, 2026
ontoolactivated and ontoolcancel attributes now supersede WebMCPEvents, which are slated for removal in a future CL. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: I2fc110b7979baecc752663e7d9b2fd4ba51d4cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653555 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705650}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 27, 2026
This is part of a transition to standardized event attributes; ontoolcancel will follow shortly, eventually replacing WebMCPEvents. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: Iffce26011963e6e501a7843e72a6ea4f6bea0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7642055 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705649}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 27, 2026
This is part of a transition to standardized event attributes; ontoolcancel will follow shortly, eventually replacing WebMCPEvents. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: Iffce26011963e6e501a7843e72a6ea4f6bea0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7642055 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705649}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 27, 2026
ontoolactivated and ontoolcancel attributes now supersede WebMCPEvents, which are slated for removal in a future CL. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: I2fc110b7979baecc752663e7d9b2fd4ba51d4cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653555 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705650}
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 6, 2026
…lactivated attribute, a=testonly Automatic update from web-platform-tests [WebMCP] Add document.modelContext.ontoolactivated attribute This is part of a transition to standardized event attributes; ontoolcancel will follow shortly, eventually replacing WebMCPEvents. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: Iffce26011963e6e501a7843e72a6ea4f6bea0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7642055 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705649} -- wpt-commits: a9871a23b1f1eccc152d592db479b08690f3fed0 wpt-pr: 62965
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 6, 2026
…lcancel attribute, a=testonly Automatic update from web-platform-tests [WebMCP] Add document.modelContext.ontoolcancel attribute ontoolactivated and ontoolcancel attributes now supersede WebMCPEvents, which are slated for removal in a future CL. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: I2fc110b7979baecc752663e7d9b2fd4ba51d4cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653555 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705650} -- wpt-commits: 2d66b9b7998bb58c336138c178323ddee857b586 wpt-pr: 62995
zerox80
pushed a commit
to zerox80/firefox
that referenced
this pull request
Oct 16, 2026
…lactivated attribute, a=testonly Automatic update from web-platform-tests [WebMCP] Add document.modelContext.ontoolactivated attribute This is part of a transition to standardized event attributes; ontoolcancel will follow shortly, eventually replacing WebMCPEvents. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: Iffce26011963e6e501a7843e72a6ea4f6bea0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7642055 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705649} -- wpt-commits: a9871a23b1f1eccc152d592db479b08690f3fed0 wpt-pr: 62965
zerox80
pushed a commit
to zerox80/firefox
that referenced
this pull request
Oct 16, 2026
…lcancel attribute, a=testonly Automatic update from web-platform-tests [WebMCP] Add document.modelContext.ontoolcancel attribute ontoolactivated and ontoolcancel attributes now supersede WebMCPEvents, which are slated for removal in a future CL. Spec PR: webmachinelearning/webmcp#146 Bug: 489045948 Change-Id: I2fc110b7979baecc752663e7d9b2fd4ba51d4cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653555 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1705650} -- wpt-commits: 2d66b9b7998bb58c336138c178323ddee857b586 wpt-pr: 62995
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #126 (comment), this PR adds new
ToolActivatedEventandToolCancelEventinterfaces.Preview | Diff