Skip to content

Comments

Fix path to git binary on Windows runners#140

Merged
mpdude merged 1 commit intomasterfrom
fix-windows-path
Oct 19, 2022
Merged

Fix path to git binary on Windows runners#140
mpdude merged 1 commit intomasterfrom
fix-windows-path

Conversation

@mpdude
Copy link
Member

@mpdude mpdude commented Oct 19, 2022

This PR fixes an apparently wrong path to the git binary that was added in #136.

According to https://github.com/actions/checkout/discussions/928#discussioncomment-3861581, the path should not contain the usr/ part, although for ssh-add and ssh-agent, it has to.

@mpdude
Copy link
Member Author

mpdude commented Oct 19, 2022

@ochococo 👀 agree?

@ochococo
Copy link
Contributor

Thanks @mpdude, good catch, LGTM 🟢

@mpdude mpdude merged commit 8a9e20a into master Oct 19, 2022
@mpdude mpdude deleted the fix-windows-path branch October 19, 2022 12:55
@sfullerbeckman
Copy link

sfullerbeckman commented Oct 19, 2022

@mpdude @ochococo , can this bugfix be released today? Would love to use this ASAP

@ochococo
Copy link
Contributor

@sfullerbeckman you can use commit instead of version: #136 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants