Skip to content

Comments

Explain how to use docker/build-push-action with deployment-key configs#133

Merged
mpdude merged 1 commit intowebfactory:masterfrom
j-riebe:patch-1
Oct 19, 2022
Merged

Explain how to use docker/build-push-action with deployment-key configs#133
mpdude merged 1 commit intowebfactory:masterfrom
j-riebe:patch-1

Conversation

@j-riebe
Copy link
Contributor

@j-riebe j-riebe commented Oct 12, 2022

This PR adds a recipe for using docker/build-push-action with multiple Deploy Keys (#78) to the docs.

@mpdude
Copy link
Member

mpdude commented Oct 19, 2022

Thank you for this contribution!

Why do you need the additional step in the workflow? Can't we keep all the necessary changes in the Dockerfile with two COPY statements there?

@mpdude mpdude changed the title Update README.md Explain how to use docker/build-push-action with deployment-key configs Oct 19, 2022
@j-riebe
Copy link
Contributor Author

j-riebe commented Oct 19, 2022

You can't access the ssh/git config from within the Dockerfile, if they are not inside docker's build context (which is the path of the checked-out repo by default).

@mpdude mpdude merged commit b19b28d into webfactory:master Oct 19, 2022
@mpdude
Copy link
Member

mpdude commented Oct 19, 2022

Thank you @j-riebe

@j-riebe j-riebe deleted the patch-1 branch October 19, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants