Skip to content

Comments

fix: implement the new GitHub host keys#101

Closed
nikolay wants to merge 1 commit intowebfactory:masterfrom
nikolay:patch-1
Closed

fix: implement the new GitHub host keys#101
nikolay wants to merge 1 commit intowebfactory:masterfrom
nikolay:patch-1

Conversation

@nikolay
Copy link

@nikolay nikolay commented Nov 17, 2021

@mpdude
Copy link
Member

mpdude commented Nov 18, 2021

Thank you @nikolay for this PR!

Adding the two new keys is definetly a good thing. The ssh-rsa key you removed, however, seems to be still supported by GitHub.

Is it really necessary to drop it? I am afraid of BC problems for users of this action, especially on older runners.

@mpdude mpdude closed this in dc622c5 Nov 20, 2021
camilo-celis pushed a commit to pexip/ssh-agent that referenced this pull request Jul 21, 2022
camilo-celis pushed a commit to pexip/ssh-agent that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants