Make executeWorkbench work after VSCode restarts#106
Merged
christian-bromann merged 3 commits intowebdriverio-community:mainfrom Feb 15, 2024
Merged
Make executeWorkbench work after VSCode restarts#106christian-bromann merged 3 commits intowebdriverio-community:mainfrom
christian-bromann merged 3 commits intowebdriverio-community:mainfrom
Conversation
`vscode.openFolder` can be used to restart the VSCode under different workspace root. In that case the current socket is closed, and then the new connection appears after the VSCode is up again. This PR clears pending message callbacks when the connection is closed, and also re-assigns the `_promisedSocket` to a new socket when new connection appears.
Co-authored-by: Sean Poulter <[email protected]>
christian-bromann
approved these changes
Feb 15, 2024
Contributor
christian-bromann
left a comment
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks a lot!
christian-bromann
requested changes
Feb 15, 2024
Contributor
christian-bromann
left a comment
christian-bromann
left a comment
There was a problem hiding this comment.
Thanks for the contribution! It seems like the added test fails in our pipeline, mind taking a look?
seanpoulter
reviewed
Feb 15, 2024
Co-authored-by: Sean Poulter <[email protected]>
Collaborator
|
Hey ilia-db 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Contributor
|
Released as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode.openFoldercan be used to restart the VSCode under different workspace root. In that case the current socket is closed, and then the new connection appears after the VSCode is up again.This PR clears pending message callbacks when the connection is closed and re-assigns the
_promisedSocketto a new socket when new connection appears.Fixes #62
Had to hard-code vscode version to
1.85.2when running tests locally, since newer chromedriver versions live in a new location. Seems like there's a PR already to fix it #105