Skip to content

Fix shrinked viewport for devtools package#6487

Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom
L0tso:fix-6471
Mar 1, 2021
Merged

Fix shrinked viewport for devtools package#6487
christian-bromann merged 5 commits intowebdriverio:mainfrom
L0tso:fix-6471

Conversation

@L0tso
Copy link
Copy Markdown
Contributor

@L0tso L0tso commented Feb 22, 2021

Proposed changes

Fix #6471

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Feb 23, 2021

@L0tso can you run the tests and see if they pass?

@L0tso
Copy link
Copy Markdown
Contributor Author

L0tso commented Feb 23, 2021

@christian-bromann Ohh, I thought PR was opened as draft :(
I have got some issues with this fix

  1. TS error from Puppeteer
    Type 'null' is not assignable to type 'Viewport | undefined' [7.0.4] Type defaultViewport can't be null (to take all window space) puppeteer/puppeteer#6885
  2. Broken snapshots
    image
    Should I close PR until the issues isn't resolved? Or add // @ts-ignore and update snapshots?

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Feb 23, 2021

Please update your branch and update the screenshot, thanks!

@dylang
Copy link
Copy Markdown
Contributor

dylang commented Feb 23, 2021

This might be related to the issue that @L0tso is running into:
puppeteer/puppeteer#6885

@dylanlive
Copy link
Copy Markdown
Contributor

dylanlive commented Feb 25, 2021

Watching this. I may want to pull it into #6508 if it is merged.

@L0tso
add @ts-ignore
3aa5fbd 
update snapshots
christian-bromann
christian-bromann reviewed Mar 1, 2021
View reviewed changes
Comment thread packages/devtools/src/launcher.ts Outdated
christian-bromann
christian-bromann reviewed Mar 1, 2021
View reviewed changes
Comment thread packages/webdriverio/src/commands/browser/getPuppeteer.ts Outdated
Comment thread packages/webdriverio/src/commands/browser/getPuppeteer.ts Outdated
christian-bromann
christian-bromann approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 1, 2021
@christian-bromann christian-bromann merged commit 77ae1c3 into webdriverio:main Mar 1, 2021
@dylanlive dylanlive mentioned this pull request Mar 5, 2021
Merged
8 tasks
This was referenced Mar 6, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Merged
Closed
@pmerwin pmerwin mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shrinked browser viewport while running the test

4 participants

@L0tso @christian-bromann @dylang @dylanlive