feat: Use no floating promise eslint rule for missing await#15084
Merged
christian-bromann merged 5 commits intowebdriverio:mainfrom Mar 7, 2026
Merged
Conversation
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
christian-bromann
force-pushed
the
add-no-floating-promise-eslint-rule
branch
from
afa2550 to
025c961
Compare
Add rule so most of the missing await for promises are trapped replace `wdio/await-expect` by `wdio/no-floating-promise` when possible Working version clear js vs ts config
christian-bromann
force-pushed
the
add-no-floating-promise-eslint-rule
branch
from
025c961 to
4d80d43
Compare
Contributor
|
Hey dprevost-LMI 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Because WDIO tests rely heavily on
await, and also since typings inexpect-webdriverioare now fixed, then TypeScript projects should enforce an ESLint rule that prevents “floating” Promises (i.e., Promises that aren’t awaited).We’ve already enabled this rule in our codebase, and it has helped developers and QA catch flaky tests caused by missing await.
ts-recommendconfig only for ts projects, else fallback on js-recommended as beforee2e/browser-runner/components/LitComponent.tsfailing ESLint by adding some missing globals in the ESLint config for e2e foldersTypes of changes
For a TypeScript project this could be seen as a breaking behavior changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-portedFurther comments
Testing
Reviewers: @webdriverio/project-committers