evaluate assertions at appropriate time#959
evaluate assertions at appropriate time#959hallvors merged 2 commits intoweb-platform-tests:masterfrom
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/1455 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Evaluate assertions at appropriate time in XMLHttpRequest/abort-event-order.html, to compliment 10010b1's corrected expected results Closes web-platform-tests#958
Per the spec, the readyState is updated after the events are dispatched. Since the assertion occurs during the final loadend event handler, there must be a pause before the readyState can be tested, as browsers behaving according to the spec will not have updated the readyState yet.
|
Rationale for the second commit in https://critic.hoppipolla.co.uk/showcomment?chain=4741 |
There was a problem hiding this comment.
In case the commit message was not clear, it is literally impossible for a compliant browser to pass this test without moving this here, because the assertions would be evaluated before all of the expected events have been dispatched
|
@hallvors would be good if you could review this (either here or at https://critic.hoppipolla.co.uk/r/1455) |
|
Looks good. Thanks for spotting that my fix was incomplete, @caitp |
evaluate assertions at appropriate time
Add missing charset declarations in compositing tests.
5 participants
Evaluate assertions at appropriate time in
XMLHttpRequest/abort-event-order.html, to compliment 10010b1's corrected
expected results
Closes #958