Add IDBIndex cursor iteration test#8119
Merged
inexorabletash merged 2 commits intoweb-platform-tests:masterfrom Nov 9, 2017
Merged
Add IDBIndex cursor iteration test#8119inexorabletash merged 2 commits intoweb-platform-tests:masterfrom
inexorabletash merged 2 commits intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
requested review from
chunywang,
dumbmatter,
inexorabletash,
odinho,
yunxiaoxie,
zhaozihao and
zqzhang
pwnall
approved these changes
Nov 8, 2017
Contributor
pwnall
left a comment
pwnall
left a comment
There was a problem hiding this comment.
LGTM w/ nit, assuming Travis passes.
Thank you very much for the test!
| cursor.continue(); | ||
| } else { | ||
| assert_equals(cursorValues.length, 4, | ||
| `Expected cursor to iterate over 4 records`); |
Contributor
There was a problem hiding this comment.
nit: The currently preferred style is "Cursor should iterate over 4 records"
Build PASSEDStarted: 2017-11-09 00:16:22 Failing Jobs
View more information about this build on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for the issue reported in this Safari bug:
https://bugs.webkit.org/show_bug.cgi?id=178995