Skip to content

Add feature-policy to battery-status#7944

Merged
Honry merged 2 commits intoweb-platform-tests:masterfrom
Honry:battery/feature-policy
Sep 25, 2019
Merged

Add feature-policy to battery-status#7944
Honry merged 2 commits intoweb-platform-tests:masterfrom
Honry:battery/feature-policy

Conversation

@Honry
Copy link
Copy Markdown
Contributor

@Honry Honry commented Oct 23, 2017

  • Add feature-policy tests
  • Disallow using battery in cross-origin iframe
  • Allow using battery in same-origin iframe

Reflect to w3c/battery#13

@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2017

Build PASSED

Started: 2017-10-23 12:22:19
Finished: 2017-10-23 12:56:17

View more information about this build on:

Copy link
Copy Markdown
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clelland to review the Feature Policy tests to ensure we've tested the edge cases correctly.

@gsnedders
Copy link
Copy Markdown
Member

Is there any reason this hasn't landed? Or are we waiting on @clelland to review half of this?

(Also, this now needs rebased given the OWNERS/META.yml migration, see #9230.)

@Honry
Copy link
Copy Markdown
Contributor Author

Honry commented Sep 4, 2018

@gsnedders, actually this PR reflects to w3c/battery#13, which is still under review. And I will rebase it soon.

 - Add feature-policy tests
 - Disallow using battery in cross-origin iframe
 - Allow using battery in same-origin iframe
 w3c/battery#13
@Honry
Copy link
Copy Markdown
Contributor Author

Honry commented Sep 25, 2019

@anssiko, tests have been up-to-date, PTAL again. Thanks!

@anssiko
Copy link
Copy Markdown
Member

anssiko commented Sep 25, 2019

Thanks @Honry, LGTM!

(The only normative change since last update to this PR was w3c/battery@3e08915 and that's now baked into this PR.)

@Honry Honry merged commit fab60f6 into web-platform-tests:master Sep 25, 2019
@Honry Honry deleted the battery/feature-policy branch September 25, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants