Moved over browsing context name tests into their appropriated directory#7637
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Oct 9, 2017
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 9, 2017
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Build PASSEDStarted: 2017-10-09 11:10:15 View more information about this build on: |
The tests where implmented here: https://chromium-review.googlesource.com/c/chromium/src/+/645309 Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName Bug: 706350 Change-Id: I88ebebe943369f04e75b1487060ad7f42f4c0769 Reviewed-on: https://chromium-review.googlesource.com/707007 Reviewed-by: Mike West <[email protected]> Commit-Queue: Andy Paicu <[email protected]> Cr-Commit-Position: refs/heads/master@{#507351}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-707007
branch
from
4119238 to
6b4ff95
Compare
foolip
added a commit
that referenced
this pull request
Oct 17, 2017
These were already moved into html/ in #7637, but because a bug in Chromium's exporter the original change was exported again: https://bugs.chromium.org/p/chromium/issues/detail?id=775439 The files still match exactly those in html/browsers/browsing-the-web/history-traversal/, with the exception of support/window-name-navigation.sub.html which has a (correctly) updated path, so there's no loss of coverage.
foolip
added a commit
that referenced
this pull request
Oct 17, 2017
These were already moved into html/ in #7637, but because a bug in Chromium's exporter the original change was exported again: https://bugs.chromium.org/p/chromium/issues/detail?id=775439 The files still match exactly those in html/browsers/browsing-the-web/history-traversal/, with the exception of support/window-name-navigation.sub.html which has a (correctly) updated path, so there's no loss of coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests where implmented here: https://chromium-review.googlesource.com/c/chromium/src/+/645309
Spec: https://html.spec.whatwg.org/multipage/browsers.html#resetBCName
Bug: 706350
Change-Id: I88ebebe943369f04e75b1487060ad7f42f4c0769
Reviewed-on: https://chromium-review.googlesource.com/707007
Reviewed-by: Mike West [email protected]
Commit-Queue: Andy Paicu [email protected]
Cr-Commit-Position: refs/heads/master@{#507351}