Skip to content

HTML: The "rendered legend" creates a block formatting context#6125

Merged
zcorpan merged 1 commit intomasterfrom
zcorpan/legend-block-formatting-context
Jun 7, 2017
Merged

HTML: The "rendered legend" creates a block formatting context#6125
zcorpan merged 1 commit intomasterfrom
zcorpan/legend-block-formatting-context

Conversation

@zcorpan
Copy link
Copy Markdown
Member

@zcorpan zcorpan commented Jun 1, 2017 •
edited by wpt-pr-bot
Loading

@wpt-pr-bot wpt-pr-bot added the html label Jun 1, 2017
@wpt-pr-bot wpt-pr-bot requested review from jdm, jgraham and zqzhang June 1, 2017 09:26
This was referenced Jun 1, 2017
Closed
Merged
zcorpan added a commit to whatwg/html that referenced this pull request Jun 1, 2017
@zcorpan
The "rendered legend" creates a new block formatting context
b945845 
Fixes #2519.

Tests: web-platform-tests/wpt#6125
@ghost
Copy link
Copy Markdown

ghost commented Jun 1, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 36c5b56
Using browser at version BuildID 20170531100318; SourceStamp 7b8937970f9ca85db88cb2496f2112175fd847c8
Starting 10 test iterations
All results were stable

All results

2 tests ran
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-block-formatting-context.html
Subtest Results Messages
OK
in-body PASS
rendered-legend PASS
in-fieldset-second-child FAIL assert_equals: legend.offsetLeft expected 2 but got 52
in-fieldset-descendant FAIL assert_equals: legend.offsetTop expected 50 but got 100
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend.html
Subtest Results Messages
OK
in-body: display PASS
in-body: unicodeBidi PASS
in-body: marginTop PASS
in-body: marginRight PASS
in-body: marginBottom PASS
in-body: marginLeft PASS
in-body: paddingTop PASS
in-body: paddingRight FAIL assert_equals: expected "2px" but got "0px"
in-body: paddingBottom PASS
in-body: paddingLeft FAIL assert_equals: expected "2px" but got "0px"
in-body: overflow PASS
in-body: height PASS
in-body: box-sizing PASS
in-body: width PASS
rendered-legend: display PASS
rendered-legend: unicodeBidi PASS
rendered-legend: marginTop PASS
rendered-legend: marginRight PASS
rendered-legend: marginBottom PASS
rendered-legend: marginLeft PASS
rendered-legend: paddingTop PASS
rendered-legend: paddingRight PASS
rendered-legend: paddingBottom PASS
rendered-legend: paddingLeft PASS
rendered-legend: overflow PASS
rendered-legend: height PASS
rendered-legend: box-sizing PASS
rendered-legend: width PASS
in-fieldset-second-child: display PASS
in-fieldset-second-child: unicodeBidi PASS
in-fieldset-second-child: marginTop PASS
in-fieldset-second-child: marginRight PASS
in-fieldset-second-child: marginBottom PASS
in-fieldset-second-child: marginLeft PASS
in-fieldset-second-child: paddingTop PASS
in-fieldset-second-child: paddingRight PASS
in-fieldset-second-child: paddingBottom PASS
in-fieldset-second-child: paddingLeft PASS
in-fieldset-second-child: overflow PASS
in-fieldset-second-child: height PASS
in-fieldset-second-child: box-sizing PASS
in-fieldset-second-child: width FAIL assert_not_equals: got disallowed value "0px"
in-fieldset-descendant: display PASS
in-fieldset-descendant: unicodeBidi PASS
in-fieldset-descendant: marginTop PASS
in-fieldset-descendant: marginRight PASS
in-fieldset-descendant: marginBottom PASS
in-fieldset-descendant: marginLeft PASS
in-fieldset-descendant: paddingTop PASS
in-fieldset-descendant: paddingRight FAIL assert_equals: expected "2px" but got "0px"
in-fieldset-descendant: paddingBottom PASS
in-fieldset-descendant: paddingLeft FAIL assert_equals: expected "2px" but got "0px"
in-fieldset-descendant: overflow PASS
in-fieldset-descendant: height PASS
in-fieldset-descendant: box-sizing PASS
in-fieldset-descendant: width PASS

@ghost
Copy link
Copy Markdown

ghost commented Jun 1, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 36c5b56
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

2 tests ran
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-block-formatting-context.html
Subtest Results Messages
OK
in-body FAIL assert_equals: legend.offsetLeft expected 0 but got 50
rendered-legend FAIL assert_equals: legend.offsetTop expected 0 but got 1
in-fieldset-second-child FAIL assert_equals: legend.offsetLeft expected 2 but got 52
in-fieldset-descendant FAIL assert_equals: legend.offsetLeft expected 2 but got 104
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend.html
Subtest Results Messages
OK
in-body: display PASS
in-body: unicodeBidi PASS
in-body: marginTop PASS
in-body: marginRight PASS
in-body: marginBottom PASS
in-body: marginLeft PASS
in-body: paddingTop PASS
in-body: paddingRight PASS
in-body: paddingBottom PASS
in-body: paddingLeft PASS
in-body: overflow PASS
in-body: height PASS
in-body: box-sizing PASS
in-body: width FAIL assert_not_equals: got disallowed value "0px"
rendered-legend: display PASS
rendered-legend: unicodeBidi PASS
rendered-legend: marginTop PASS
rendered-legend: marginRight PASS
rendered-legend: marginBottom PASS
rendered-legend: marginLeft PASS
rendered-legend: paddingTop PASS
rendered-legend: paddingRight PASS
rendered-legend: paddingBottom PASS
rendered-legend: paddingLeft PASS
rendered-legend: overflow PASS
rendered-legend: height PASS
rendered-legend: box-sizing PASS
rendered-legend: width PASS
in-fieldset-second-child: display PASS
in-fieldset-second-child: unicodeBidi PASS
in-fieldset-second-child: marginTop PASS
in-fieldset-second-child: marginRight PASS
in-fieldset-second-child: marginBottom PASS
in-fieldset-second-child: marginLeft PASS
in-fieldset-second-child: paddingTop PASS
in-fieldset-second-child: paddingRight PASS
in-fieldset-second-child: paddingBottom PASS
in-fieldset-second-child: paddingLeft PASS
in-fieldset-second-child: overflow PASS
in-fieldset-second-child: height PASS
in-fieldset-second-child: box-sizing PASS
in-fieldset-second-child: width FAIL assert_not_equals: got disallowed value "0px"
in-fieldset-descendant: display PASS
in-fieldset-descendant: unicodeBidi PASS
in-fieldset-descendant: marginTop PASS
in-fieldset-descendant: marginRight PASS
in-fieldset-descendant: marginBottom PASS
in-fieldset-descendant: marginLeft PASS
in-fieldset-descendant: paddingTop PASS
in-fieldset-descendant: paddingRight PASS
in-fieldset-descendant: paddingBottom PASS
in-fieldset-descendant: paddingLeft PASS
in-fieldset-descendant: overflow PASS
in-fieldset-descendant: height PASS
in-fieldset-descendant: box-sizing PASS
in-fieldset-descendant: width FAIL assert_not_equals: got disallowed value "0px"

@ghost
Copy link
Copy Markdown

ghost commented Jun 1, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 36c5b56
Using browser at version 60.0.3112.7 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-block-formatting-context.html
Subtest Results Messages
OK
in-body FAIL assert_equals: legend.offsetLeft expected 0 but got 50
rendered-legend FAIL assert_equals: legend.offsetTop expected 0 but got 1
in-fieldset-second-child FAIL assert_equals: legend.offsetLeft expected 2 but got 52
in-fieldset-descendant FAIL assert_equals: legend.offsetLeft expected 2 but got 104
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend.html
Subtest Results Messages
OK
in-body: display PASS
in-body: unicodeBidi FAIL assert_equals: expected "isolate" but got "normal"
in-body: marginTop PASS
in-body: marginRight PASS
in-body: marginBottom PASS
in-body: marginLeft PASS
in-body: paddingTop PASS
in-body: paddingRight PASS
in-body: paddingBottom PASS
in-body: paddingLeft PASS
in-body: overflow PASS
in-body: height PASS
in-body: box-sizing PASS
in-body: width FAIL assert_not_equals: got disallowed value "0px"
rendered-legend: display PASS
rendered-legend: unicodeBidi FAIL assert_equals: expected "isolate" but got "normal"
rendered-legend: marginTop PASS
rendered-legend: marginRight PASS
rendered-legend: marginBottom PASS
rendered-legend: marginLeft PASS
rendered-legend: paddingTop PASS
rendered-legend: paddingRight PASS
rendered-legend: paddingBottom PASS
rendered-legend: paddingLeft PASS
rendered-legend: overflow PASS
rendered-legend: height PASS
rendered-legend: box-sizing PASS
rendered-legend: width PASS
in-fieldset-second-child: display PASS
in-fieldset-second-child: unicodeBidi FAIL assert_equals: expected "isolate" but got "normal"
in-fieldset-second-child: marginTop PASS
in-fieldset-second-child: marginRight PASS
in-fieldset-second-child: marginBottom PASS
in-fieldset-second-child: marginLeft PASS
in-fieldset-second-child: paddingTop PASS
in-fieldset-second-child: paddingRight PASS
in-fieldset-second-child: paddingBottom PASS
in-fieldset-second-child: paddingLeft PASS
in-fieldset-second-child: overflow PASS
in-fieldset-second-child: height PASS
in-fieldset-second-child: box-sizing PASS
in-fieldset-second-child: width FAIL assert_not_equals: got disallowed value "0px"
in-fieldset-descendant: display PASS
in-fieldset-descendant: unicodeBidi FAIL assert_equals: expected "isolate" but got "normal"
in-fieldset-descendant: marginTop PASS
in-fieldset-descendant: marginRight PASS
in-fieldset-descendant: marginBottom PASS
in-fieldset-descendant: marginLeft PASS
in-fieldset-descendant: paddingTop PASS
in-fieldset-descendant: paddingRight PASS
in-fieldset-descendant: paddingBottom PASS
in-fieldset-descendant: paddingLeft PASS
in-fieldset-descendant: overflow PASS
in-fieldset-descendant: height PASS
in-fieldset-descendant: box-sizing PASS
in-fieldset-descendant: width FAIL assert_not_equals: got disallowed value "0px"

@ghost
Copy link
Copy Markdown

ghost commented Jun 1, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 36c5b56
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

2 tests ran
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend-block-formatting-context.html
Subtest Results Messages
OK
in-body FAIL assert_equals: legend.offsetLeft expected 0 but got 50
rendered-legend FAIL assert_equals: legend.offsetLeft expected 2 but got 52
in-fieldset-second-child FAIL assert_equals: legend.clientHeight expected 0 but got 50
in-fieldset-descendant FAIL assert_equals: legend.offsetTop expected 50 but got 100
/html/rendering/non-replaced-elements/the-fieldset-element-0/legend.html
Subtest Results Messages
OK
in-body: display FAIL assert_equals: expected "block" but got "inline"
in-body: unicodeBidi PASS
in-body: marginTop PASS
in-body: marginRight PASS
in-body: marginBottom PASS
in-body: marginLeft PASS
in-body: paddingTop PASS
in-body: paddingRight PASS
in-body: paddingBottom PASS
in-body: paddingLeft PASS
in-body: overflow PASS
in-body: height PASS
in-body: box-sizing PASS
in-body: width FAIL assert_not_equals: got disallowed value "0px"
rendered-legend: display FAIL assert_equals: expected "block" but got "inline"
rendered-legend: unicodeBidi PASS
rendered-legend: marginTop PASS
rendered-legend: marginRight PASS
rendered-legend: marginBottom PASS
rendered-legend: marginLeft PASS
rendered-legend: paddingTop PASS
rendered-legend: paddingRight PASS
rendered-legend: paddingBottom PASS
rendered-legend: paddingLeft PASS
rendered-legend: overflow PASS
rendered-legend: height PASS
rendered-legend: box-sizing PASS
rendered-legend: width PASS
in-fieldset-second-child: display FAIL assert_equals: expected "block" but got "inline"
in-fieldset-second-child: unicodeBidi PASS
in-fieldset-second-child: marginTop PASS
in-fieldset-second-child: marginRight PASS
in-fieldset-second-child: marginBottom PASS
in-fieldset-second-child: marginLeft PASS
in-fieldset-second-child: paddingTop PASS
in-fieldset-second-child: paddingRight PASS
in-fieldset-second-child: paddingBottom PASS
in-fieldset-second-child: paddingLeft PASS
in-fieldset-second-child: overflow PASS
in-fieldset-second-child: height PASS
in-fieldset-second-child: box-sizing PASS
in-fieldset-second-child: width FAIL assert_not_equals: got disallowed value "0px"
in-fieldset-descendant: display FAIL assert_equals: expected "block" but got "inline"
in-fieldset-descendant: unicodeBidi PASS
in-fieldset-descendant: marginTop PASS
in-fieldset-descendant: marginRight PASS
in-fieldset-descendant: marginBottom PASS
in-fieldset-descendant: marginLeft PASS
in-fieldset-descendant: paddingTop PASS
in-fieldset-descendant: paddingRight PASS
in-fieldset-descendant: paddingBottom PASS
in-fieldset-descendant: paddingLeft PASS
in-fieldset-descendant: overflow PASS
in-fieldset-descendant: height PASS
in-fieldset-descendant: box-sizing PASS
in-fieldset-descendant: width FAIL assert_not_equals: got disallowed value "0px"

@zcorpan zcorpan requested a review from mstensho June 5, 2017 13:06
mstensho
mstensho reviewed Jun 6, 2017
View reviewed changes
.../rendering/non-replaced-elements/the-fieldset-element-0/legend-block-formatting-context.html

<div class=wrapper>
<fieldset>
<div class=float></div>
Copy link
Copy Markdown
Contributor

@mstensho mstensho Jun 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://html.spec.whatwg.org/multipage/forms.html#the-legend-element says that LEGEND needs to be the first child of the FIELDSET. Will #rendered-legend really become a rendered legend here?

Copy link
Copy Markdown
Member Author

@zcorpan zcorpan Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. https://html.spec.whatwg.org/#rendered-legend says what is the rendered legend. What you cite is an authoring requirement.

Copy link
Copy Markdown
Contributor

@mstensho mstensho Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I suppose I forgot to read the entire spec backwards again. :)

zcorpan added a commit to whatwg/html that referenced this pull request Jun 7, 2017
@zcorpan
The "rendered legend" creates a new block formatting context
7ef1599 
Fixes #2519.

Tests: web-platform-tests/wpt#6125
@zcorpan zcorpan merged commit 100ec1e into master Jun 7, 2017
@zcorpan zcorpan deleted the zcorpan/legend-block-formatting-context branch June 7, 2017 12:30
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@zcorpan
The "rendered legend" creates a new block formatting context
9e4bcb0 
Fixes whatwg#2519.

Tests: web-platform-tests/wpt#6125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstensho mstensho mstensho approved these changes

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

No one assigned

Labels

html html-fieldset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zcorpan @mstensho @wpt-pr-bot