layout: Fix first-paint detection#58544
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Mar 20, 2026
Merged
layout: Fix first-paint detection#58544servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
first-paint detection#58544servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 17, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
9c7af18 to
91427bb
Compare
Signed-off-by: Shubham Gupta <[email protected]>
91427bb to
172f03e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comprises
paintableandcontentful.first-paint.is_paintabletodisplay_listand use same for markingfirst-paint.TODO: This doesn't consider
iframes. Will add PR after fixing WPT tests.Raised an issue for some incomplete definitions: w3c/paint-timing#122
Testing:
wpt/tests/paint-timing/first-paint-only/first-paint-bg-color.htmlwpt/paint-timing/first-image-child.htmlwpt/paint-timing/first-paint-only/sibling-painting-first-image.htmlservo/tests/performance_paint_timings.rs. Following Tests Cases are covered:test_default_pref_with_unset_backgroundtest_non_default_pref_with_unset_backgroundtest_default_pref_with_transparent_backgroundtest_non_default_pref_with_transparent_backgroundtest_default_pref_with_backgroundtest_non_default_pref_with_backgroundtest_non_default_pref_with_same_backgroundFixes: #42148
Reviewed in servo/servo#42975