webdriver: Support interspersed scroll actions via event queue#58388
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Mar 11, 2026
Merged
webdriver: Support interspersed scroll actions via event queue#58388servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 10, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
bcf0fc5 to
e52925e
Compare
Contributor
|
@whimboo Would you like to review the test? |
8893c67 to
c72b299
Compare
Signed-off-by: Euclid Ye <[email protected]>
c72b299 to
01d2f81
Compare
Contributor
|
I would just merge this since I have follow-up that depends on this, and it's been reviewed in Servo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scroll and PointerMove is quite similar. We did so for
PointeMovein servo/servo#42289 + servo/servo#42946.Imagine having 3 non-zero duration scroll actions with origin at different Elements.
Previously we would wait for one to be fully dispatched before moving to next action,
instead of interspersed.
We also consolidate
PendingPointerMoveandnewly added
PendingScrollintoenum PendingActions.Testing:
Existing tests behaviour not changing.. Added a wdspec test.
Previously:
['wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'move']Now:
['wheel', 'move', 'wheel', 'move', 'wheel', 'move', 'move', 'wheel', 'wheel', 'move', 'move', 'wheel', 'wheel', 'move', 'move', 'wheel']Reviewed in servo/servo#43126