Skip to content

webdriver: Support interspersed scroll actions via event queue#58388

Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_43126
Mar 11, 2026
Merged

webdriver: Support interspersed scroll actions via event queue#58388
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_43126

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

@servo-wpt-sync servo-wpt-sync commented Mar 10, 2026

Scroll and PointerMove is quite similar. We did so for PointeMove in servo/servo#42289 + servo/servo#42946.

Imagine having 3 non-zero duration scroll actions with origin at different Elements.
Previously we would wait for one to be fully dispatched before moving to next action,
instead of interspersed.

We also consolidate PendingPointerMove and
newly added PendingScroll into enum PendingActions.

Testing:
Existing tests behaviour not changing.. Added a wdspec test.
Previously: ['wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'wheel', 'move']
Now: ['wheel', 'move', 'wheel', 'move', 'wheel', 'move', 'move', 'wheel', 'wheel', 'move', 'move', 'wheel', 'wheel', 'move', 'move', 'wheel']

Reviewed in servo/servo#43126

Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@yezhizhen
Copy link
Copy Markdown
Contributor

yezhizhen commented Mar 10, 2026

@whimboo Would you like to review the test?

@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_43126 branch 2 times, most recently from 8893c67 to c72b299 Compare March 10, 2026 11:22
@yezhizhen
Copy link
Copy Markdown
Contributor

I would just merge this since I have follow-up that depends on this, and it's been reviewed in Servo.
But feel free to ping me later :)

@servo-wpt-sync servo-wpt-sync merged commit ce3578c into web-platform-tests:master Mar 11, 2026
24 checks passed
@servo-wpt-sync servo-wpt-sync deleted the servo_export_43126 branch March 11, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants