Remove the early return, as this doesn't let evaluate the below assertions in the test.#58243
Merged
noamr merged 1 commit intoweb-platform-tests:masterfrom Mar 16, 2026
Merged
Conversation
shubhamg13
force-pushed
the
fix_fp_iframe
branch
from
64e60b4 to
9d0eebf
Compare
shubhamg13
force-pushed
the
fix_fp_iframe
branch
from
9d0eebf to
033155e
Compare
shubhamg13
changed the title
shubhamg13
force-pushed
the
fix_fp_iframe
branch
2 times, most recently
from
dc2095a to
5fc8f39
Compare
Contributor
|
What is the change to 30 for? |
Contributor
Author
I tested with 20. It is acting flaky. With 30 it is fine. So, 30. Any thoughts... |
noamr
approved these changes
Mar 4, 2026
Contributor
Author
|
Please merge. Thanks |
Contributor
Seems flaky on chromium bots. |
Contributor
Author
The one failing, is not related with this one. |
shubhamg13
force-pushed
the
fix_fp_iframe
branch
from
b9fd643 to
280a531
Compare
…ions in the test. Signed-off-by: Shubham Gupta <[email protected]>
shubhamg13
force-pushed
the
fix_fp_iframe
branch
from
280a531 to
a4a3300
Compare
wpt-pr-bot
added
largest-contentful-paint
long-animation-frame
mediacapture-fromelement
payment-request
pointerevents
requirements_tests.txt
selectors
shadow-dom
svg
uievents
web-animations
WebCryptoAPI
webdriver
webdriver-bidi
webrtc
webrtc-encoded-transform
wg-cg_wicg
wg-css
wg-i18n_i18n-activity_i18n
wg-s_browser-tools-testing
wg-s_css
wg-s_payments
wg-s_pointer-events
labels
Contributor
Author
|
Can this be merged… P.S: It mistakenly added lot of reviewers |
Contributor
Author
|
cc: @xiaochengh |
Contributor
|
I think this change causes actual flakiness |
Contributor
Author
The flaky one is not related with the changes in this. |
Contributor
Author
|
Thanks a lot. Really appreciate that. |
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below code is unreached because of this early return.