Fix Range::extractContents() out-of-bounds extraction bug#58132
Merged
Conversation
When Range::extractContents() processes nodes, it may fire synchronous events (such as iframe 'unload'). If an event listener removes the Range's end container from the DOM, the extraction process could lose its end boundary. In this case, it would previously continue extracting elements out-of-bounds up to the end of the common root container. This CL fixes the issue by validating that the original end container is still a descendant of the common root. If it has been disconnected, the extraction loop aborts early. See also: whatwg/dom#1446 Fixed: 486423704 Change-Id: Ife2173713df70dd77f6fd29c593aa5f72d88ab24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7615530 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1591852}
wpt-pr-bot
approved these changes
Feb 27, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Range::extractContents() processes nodes, it may fire synchronous
events (such as iframe 'unload'). If an event listener removes the
Range's end container from the DOM, the extraction process could lose
its end boundary. In this case, it would previously continue extracting
elements out-of-bounds up to the end of the common root container.
This CL fixes the issue by validating that the original end container is
still a descendant of the common root. If it has been disconnected, the
extraction loop aborts early.
See also:
whatwg/dom#1446
Fixed: 486423704
Change-Id: Ife2173713df70dd77f6fd29c593aa5f72d88ab24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7615530
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1591852}