layout: Remove box damage for parent when we can reuse the box#58075
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Feb 26, 2026
Merged
layout: Remove box damage for parent when we can reuse the box#58075servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Feb 26, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
This fixes an oversight from web-platform-tests#42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children. Co-authored-by: Luke Warlow <[email protected]> Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>
f68541a to
f8cbc80
Compare
5c3a694
into
web-platform-tests:master
24 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an oversight from #42783: when detecting that a box can be reused, we weren't clearing the box damage propagated to ancestors, so ancestors were still recollecting children.
This exposed some problems in
rebuild_box_tree_from_independent_formatting_context():orderhad changed.Testing: we have test coverage for the 3 problems above:
/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display.html, and also adding a new/css/css-display/display-flow-root-dynamic.html./css/CSS2/abspos/hypothetical-box-dynamic.html/css/css-display/order-dynamic.html.Reviewed in layout: Remove box damage for parent when we can reuse the box servo/servo#42847