script: Fix crash when failed requests finish from a previous generation#57650
Merged
jdm merged 1 commit intoweb-platform-tests:masterfrom Mar 4, 2026
Merged
script: Fix crash when failed requests finish from a previous generation#57650jdm merged 1 commit intoweb-platform-tests:masterfrom
jdm merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Feb 9, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Most likely a regression introduced in web-platform-tests#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes web-platform-tests#42477 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42481
branch
from
ba14546 to
0f6b5e8
Compare
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#42481), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Contributor
|
@jdm this PR would appreciate a nudge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most likely a regression introduced in #42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests).
Fixes #42477
Reviewed in servo/servo#42481