testdriver harness: Allow duration 0 for actions/tick#57607
testdriver harness: Allow duration 0 for actions/tick#57607jdm merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_42398
branch
from
8eeed47 to
d53d305
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
servo-wpt-sync
force-pushed
the
servo_export_42398
branch
from
d53d305 to
4fc2517
Compare
Signed-off-by: Euclid Ye <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42398
branch
from
4fc2517 to
b3e5933
Compare
servo-wpt-sync
added
stale-servo-export
|
⛔ The downstream PR has merged (servo/servo#42398), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
|
I see no issue in CI tho. Edit: Oh. Just realise this one requires wpt-core-team. |
|
When I click web-platform-tests/wpt-core-team, it says 404 tho.. |
|
cc @web-platform-tests/wpt-core-team |
|
We can't seem to mention the team too.. |
|
The change looks ok to me but I wonder if we should add a test for it. The behavior can be verified that only a single event is emitted when performing an action chain. But I'll leave this to the platform core team. |
|
@whimboo Thanks for taking a look. Do you know any member of the team? It seems very mysterious right now and I don't know who we can reach out to.. |
|
You already CC'ed @jgraham so lets wait for his reply. |
As titled. The change is prepared a while ago to eliminate dead code, but the test case added requires change from `testdriver-actions.js`: web-platform-tests/wpt#57607 just landed by latest wpt-sync: #42925. Part of #41923 Testing: Added a WPT test. Fixes: #42921 --------- Signed-off-by: Euclid Ye <[email protected]>
As titled. The change is prepared a while ago to eliminate dead code, but the test case added requires change from `testdriver-actions.js`: web-platform-tests/wpt#57607 just landed by latest wpt-sync: #42925. Part of #41923 Testing: Added a WPT test. Fixes: #42921 --------- Signed-off-by: Euclid Ye <[email protected]>
…o#42926) As titled. The change is prepared a while ago to eliminate dead code, but the test case added requires change from `testdriver-actions.js`: web-platform-tests/wpt#57607 just landed by latest wpt-sync: servo#42925. Part of servo#41923 Testing: Added a WPT test. Fixes: servo#42921 --------- Signed-off-by: Euclid Ye <[email protected]>
7 participants
Previously, even if you explicitly set duration 0, it still ends up with
None.But you can set duration 0 in wdspec python tests.
This complies with spec: duration can be greater than or equal to 0.
Testing: There is no existing testdriver tests that use duration 0.
Fixes: #57606
Found in: servo/servo#42387 (comment)
Reviewed in servo/servo#42398