layout: Do not consider pseudo-elements widgets for the purposes of replaced content#57567
Merged
servo-wpt-sync merged 2 commits intoweb-platform-tests:masterfrom Feb 5, 2026
Merged
Conversation
wpt-pr-bot
approved these changes
Feb 4, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_42332
branch
4 times, most recently
from
ee5dad1 to
0621e8e
Compare
When an element has an image content value or list-style-image value they end up duplicating the content of the element inside the generated '::marker'. This is caused by code inside IndependentFormattingContext for user agent widgets (all user agent shadow dom), this code is specifically aimed at video and audio elements. This patch adapts that code to be more specific to elements without a pseudo-element chain (e.g. audio and video) Signed-off-by: Luke Warlow <[email protected]>
Signed-off-by: Luke Warlow <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42332
branch
from
0621e8e to
f46ed3f
Compare
servo-wpt-sync
changed the title
servo-wpt-sync
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an element has an image content value or list-style-image value they end up duplicating the content of the element inside the generated '::marker'.
This is caused by code inside IndependentFormattingContext for user agent widgets (all user agent shadow dom), this code is specifically aimed at video and audio elements.
This patch adapts that code to be more specific to elements without a pseudo-element chain (e.g. audio and video)
Testing: newly added test crashes on main servo (slightly flakily), but passes consistently now.
Fixes: #42329
Fixes: #41231
Reviewed in servo/servo#42332