layout: Handle zero-sized positioning areas when laying out a dimension for background-repeat#57530
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Feb 4, 2026
Conversation
wpt-pr-bot
approved these changes
Feb 3, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
…areas When dimensions of these areas are zero, this causes the math to calculate background repeat to produce NaN values -- leading to crashes in WebRender. When they are empty, we don't want to render a background anyway, so just exit early. Signed-off-by: Martin Robinson <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42303
branch
from
b5cfd35 to
e0db944
Compare
servo-wpt-sync
changed the title
background-repeat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification says that the rounding of the tile size should only happen
when the positioning size is not zero. This change makes us follow the
specification in this case.
Testing: This PR adds a new WPT crash test.
Fixes: #42216
Reviewed in servo/servo#42303