script: add force option for assign-slottables for a tree#57471
Merged
servo-wpt-sync merged 2 commits intoweb-platform-tests:masterfrom Feb 2, 2026
Merged
script: add force option for assign-slottables for a tree#57471servo-wpt-sync merged 2 commits intoweb-platform-tests:masterfrom
servo-wpt-sync merged 2 commits intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Feb 1, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_42250
branch
from
cac19dc to
301613d
Compare
…test testing this behaviour Signed-off-by: rayguo17 <[email protected]>
Signed-off-by: rayguo17 <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42250
branch
from
301613d to
a1b9076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of node removal, if the subtree of the removed node contains
<slot>element, force traverse down to each<slot>element is needed to reset the assignment of the slottables that currently being assigned to the<slot>element. This changes add this force option toassign_slottables_for_a_tree, and only set true to node removal.Testing: Should be covered by current WPT test, try run
Fixes servo/servo#35188
Fixes servo/servo#42182
cc @TimvdLippe @simonwuelker @xiaochengh
Reviewed in servo/servo#42250