script: Fix handling changes to relevant attributes for stylesheets#57469
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Feb 2, 2026
Merged
Conversation
wpt-pr-bot
approved these changes
Feb 1, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_42273
branch
5 times, most recently
from
018af32 to
2fdf9ca
Compare
We weren't removing stylesheets when we should be doing so. This most notably happens when the stylesheet no longer has a href or its "rel" changes. The crash is also fixed, since the issue was that we were passing the value of the attribute that was changed as if it were an href. However, if we set the type attribute, then that's not the href. To fix that, we now retrieve the href inside the method so we always have the correct value. Fixes web-platform-tests#42259 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42273
branch
from
2fdf9ca to
bca9a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't removing stylesheets when we should be doing so. This most notably happens when the stylesheet no longer has a href or its "rel" changes.
The crash is also fixed, since the issue was that we were passing the value of the attribute that was changed as if it were an href. However, if we set the type attribute, then that's not the href.
To fix that, we now retrieve the href inside the method so we always have the correct value.
Fixes #42259
Reviewed in servo/servo#42273