wdspec tests: Null "implicit wait" should not have timer#57332
Closed
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Closed
wdspec tests: Null "implicit wait" should not have timer#57332servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Jan 26, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Contributor
Signed-off-by: Euclid Ye <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42158
branch
from
8abb0f0 to
5609a42
Compare
Contributor
I think you misinterpret these referenced lines. We only start the timer when the value is not
|
Contributor
Ah, that makes sense. I wonder if we should make spec clearer with |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 30, 2026
So far for `None` [timeout](https://w3c.github.io/webdriver/#dfn-timeouts-configuration), we've treated it effectively as no wait which is wrong: web-platform-tests/wpt#57332 (comment). This PR makes all `None` timeouts wait indefinitely. The funny part is, we somehow have only done it correctly for `pageload`: https://w3c.github.io/webdriver/#dfn-timeouts-configuration Testing: We add test for script execution with `None` script timeout. --------- Signed-off-by: Euclid Ye <[email protected]>
RichardTjokroutomo
pushed a commit
to RichardTjokroutomo/servo
that referenced
this pull request
Feb 6, 2026
So far for `None` [timeout](https://w3c.github.io/webdriver/#dfn-timeouts-configuration), we've treated it effectively as no wait which is wrong: web-platform-tests/wpt#57332 (comment). This PR makes all `None` timeouts wait indefinitely. The funny part is, we somehow have only done it correctly for `pageload`: https://w3c.github.io/webdriver/#dfn-timeouts-configuration Testing: We add test for script execution with `None` script timeout. --------- Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implicit wait is
None, we should not wait at all: #57151 (comment)See step 5 of https://w3c.github.io/webdriver/#dfn-find
Reviewed in servo/servo#42158