script: Fix render blocking stylesheet load fire ordering#57306
Closed
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Closed
script: Fix render blocking stylesheet load fire ordering#57306servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Jan 23, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_41973
branch
from
0f03b0a to
d69a87b
Compare
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41973
branch
from
d69a87b to
45e582a
Compare
Collaborator
Author
|
👋 Downstream pull request (servo/servo#41973) no longer contains any upstreamable changes. Closing pull request without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding various spec comments to the parts of
#the-end(which are scattered throughout the script crate), I stumbled upon the render blocking stylesheets implementation. There was a HTML PR to make clear when it should run and the corresponding WPT tests have been fixed.Fixes #22715
Reviewed in servo/servo#41973