script: Fix handling of invalid fetch responses for link stylesheets#57295
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Jan 24, 2026
Merged
Conversation
wpt-pr-bot
approved these changes
Jan 22, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
4 tasks
servo-wpt-sync
force-pushed
the
servo_export_42037
branch
3 times, most recently
from
9799e68 to
96f626b
Compare
These should cause it to fail, regardless of the Ok status. To do so, we remove the `bool` and use the `Option` to convey success/failure. It also realigns some of the spec text to now only do it for link elements, since for styles we shouldn't be checking the result of the content type. Part of web-platform-tests#22715 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_42037
branch
from
96f626b to
efaf983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regardless of the
Okstatus, we should always create astylesheet. However, the determining of the load/error event
is based on whether it has parsed actual content or not.
It also realigns some of the spec text to now only do it for link
elements, since for styles we shouldn't be checking the result of
the content type.
Part of #22715
Reviewed in servo/servo#42037