[Gecko Bug 2008345] [webdriver-client] Support "null" value when setting timeouts.#57151
Merged
moz-wptsync-bot merged 5 commits intomasterfrom Jan 14, 2026
Merged
[Gecko Bug 2008345] [webdriver-client] Support "null" value when setting timeouts.#57151moz-wptsync-bot merged 5 commits intomasterfrom
moz-wptsync-bot merged 5 commits intomasterfrom
Conversation
Differential Revision: https://phabricator.services.mozilla.com/D278487 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008345 gecko-commit: a8f75998183421433743380aaae9acf594805bf2 gecko-reviewers: jdescottes
…t to "null". Differential Revision: https://phabricator.services.mozilla.com/D278488 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008345 gecko-commit: a98e106b55b05c2ea1cebb42d15e3b83af6e6768 gecko-reviewers: jdescottes
wpt-pr-bot
approved these changes
Jan 13, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
…eLoad" timeouts are set to "null". " for causing build bustages @rust.mk. This reverts commit c85534cff4bdb560f49722c2a7c2aba9b311742a. Revert "Bug 2008345 - [webdriver-client] Support "null" value when setting timeouts. r=jdescottes" This reverts commit 77e77081f54b90373fc027c78544d53acdfebc65. Revert "Bug 2008345 - [geckodriver] Allow "null" for "implicit" and "pageLoad" timeouts. r=geckodriver-reviewers,jdescottes,jgraham" This reverts commit 3c8816932cb09d8dc890a4c3f5005199ab9842be. Revert "Bug 2008345 - [marionette] Don't use TimedPromise if pageload timeout is "null". r=jdescottes" This reverts commit 43e61790716f1a1d1cab7902953a74bd25e47e1f. Revert "Bug 2008345 - [remote] Allow "null" for "implicit" and "pageLoad" timeouts. r=jdescottes" This reverts commit 6c232d4bd431761355a15d17a94c0b5572dca4b4. gecko-commit: fdb7dd7448fc14e7e730468e7dfbaf4ea6c41efd gecko-reviewers: jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D278487 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008345 gecko-commit: 8e1f4ed0592eb18bdfe44f3c9527e71405c71fa1 gecko-reviewers: jdescottes
…t to "null". Differential Revision: https://phabricator.services.mozilla.com/D278488 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008345 gecko-commit: ebfab89fc1d595c0d422036369592c203e4a618e gecko-reviewers: jdescottes
yezhizhen
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D278487
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2008345
gecko-commit: a8f75998183421433743380aaae9acf594805bf2
gecko-reviewers: jdescottes