layout: Treat <audio> as replaced and do not display when there is no controls attribute#56739
Merged
Loirooriol merged 1 commit intoweb-platform-tests:masterfrom Dec 15, 2025
Merged
Conversation
wpt-pr-bot
approved these changes
Dec 15, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#41262), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Add an important UA style to ensure that `<audio>` isn't displayed at all when it doesn't have the `controls` attribute. This matches Gecko, Blink and WebKit. When it does have the attribute, then treat it as replaced. For example, this means that it won't stretch by default if it's block-level, that it will be atomic if inline-level, and that it won't generate `::before` or `::after`. Previously we were generating `::before` and `::after`, but there was a bug: if they had some replaced content, the controls of the `<audio>` would be duplicated, and also appear on the pseudo-element. Then, since the various boxes for the controls would be backed by the same elements, Servo could panic because of a double borrow. This is now avoided. Signed-off-by: Oriol Brufau <[email protected]>
Loirooriol
force-pushed
the
servo_export_41262
branch
from
b2eb352 to
72c2b28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an important UA style to ensure that
<audio>isn't displayed at all when it doesn't have thecontrolsattribute. This matches Gecko, Blink and WebKit.When it does have the attribute, then treat it as replaced. For example, this means that it won't stretch by default if it's block-level, that it will be atomic if inline-level, and that it won't generate boxes for its children (including
::beforeand::after).Previously we were generating
::beforeand::after, but there was a bug: if they had some replaced content, the controls of the<audio>would be duplicated, and also appear on the pseudo-element. Then, since the various boxes for the controls would be backed by the same elements, Servo could panic because of a double borrow. This is now avoided.Testing: Some WPT are now passing, also adding a new crashtest. There is one failure about
innerText, but the test is probably wrong, now we match other browsers.Fixes: #40693
Fixes: #41183
Reviewed in servo/servo#41262