script: Update media to include fix for AudioBufferSourceNode.loop#56621
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Dec 10, 2025
Merged
Conversation
Signed-off-by: Taym Haddadi <[email protected]>
wpt-pr-bot
approved these changes
Dec 9, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
merged commit f618291
into
web-platform-tests:master
23 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix in servo/media#476:
Previously:
the moment we set bufferSource.loop = true, the node hit the early “extreme edge case” check, decided “I refuse to output”, triggered onended, and returned silence. So the loop never got a chance to run.
Now:
Early bailout is removed(no idea why was there in first place).
The per tick offset is guaranteed to be a sensible value with respect to the loop range (wrapped if extreme).
The normal mixing code runs, updating pos each tick and respecting the loop region
Testing: I tested this manually, it would be nice to add a test for it, and I’m surprised there isn’t one yet.
Fixes: #41073
Reviewed in servo/servo#41075