layout: Ensure that background-repeat: round size calculation rounds to nearest natural number#56595
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Dec 10, 2025
Conversation
wpt-pr-bot
approved these changes
Dec 9, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
…s to nearest natural number The previous code was just rounding to the nearest integrer, while the specification says to round to the nearest natural number. The prevents `inf` and `NaN` values from creeping to the results. This was leading to a crash in WebRender. Signed-off-by: Martin Robinson <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41158
branch
from
d88749a to
4d381f4
Compare
servo-wpt-sync
merged commit 30df11e
into
web-platform-tests:master
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was just rounding to the nearest integrer, while the
specification says to round to the nearest natural number. The prevents
infandNaNvalues from creeping to the results. This was leading toa crash in WebRender.
Testing: This change adds a crash test.
Fixes: #41130.
Reviewed in servo/servo#41158