webgl: Unconditionally decrement busy count of WebGL contexts.#56545
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Dec 6, 2025
Merged
webgl: Unconditionally decrement busy count of WebGL contexts.#56545servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Dec 6, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
The current logic returns early without decrementing the busy count if there are the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in `remove_webgl_context` to skip freeing the context and associated resources. Fixes web-platform-tests#41082. Signed-off-by: Mukilan Thiyagarajan <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41094
branch
from
c53039a to
bcf0763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic returns early without decrementing the busy count if the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in
remove_webgl_contextto skip freeing the context and associated resources.Fixes #41082.
Testing: A new crash test is added.
Reviewed in servo/servo#41094