dom: Avoid crashing on empty favicon href attribute#56521
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Dec 6, 2025
Merged
dom: Avoid crashing on empty favicon href attribute#56521servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
href attribute#56521servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Dec 5, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Add a check to handle_favicon_url() similar to the ones done in similar functions: handle_stylesheet_url() and fetch_and_process_prefetch_link() Signed-off-by: webbeef <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_41056
branch
from
0b05bce to
ec51af6
Compare
servo-wpt-sync
changed the title
href attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check to handle_favicon_url() similar to the ones done in similar functions: handle_stylesheet_url() and fetch_and_process_prefetch_link()
Testing: Check that loading http://chiptune.com/ doesn't crash anymore.
Fixes: servo/servo#41047
Reviewed in servo/servo#41056