layout: Cleanup for replaced elements with widgets#56153
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Nov 20, 2025
Merged
layout: Cleanup for replaced elements with widgets#56153servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom
Conversation
Signed-off-by: Oriol Brufau <[email protected]>
wpt-pr-bot
approved these changes
Nov 20, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the changes done in #40578.
In particular, it removes the unnecessary
Contents::ReplacedWithWidgetsince we can handle that withContents::Replaced. It also removesIndependentFormattingContextContents::ReplacedWithWidgetin favor ofIndependentFormattingContextContents::Replaced, by adding an optional parameter for the widget.That ensures that the behavior of replaced elements won't accidentally diverge dependign on whether they have a widget. For example, #40578 forgot to handle
ReplacedWithWidgetintentative_block_content_size().Additionally, this removes the hardcoded especial behavior for
<video>that was added inServoThreadSafeLayoutElement::with_pseudo().Testing: Adding a reftest
Fixes: #40708
Fixes: #40770
Reviewed in servo/servo#40769