servodriver: Shut down Servo elegantly when all tests finish#55907
Merged
jdm merged 6 commits intoweb-platform-tests:masterfrom Nov 16, 2025
Merged
servodriver: Shut down Servo elegantly when all tests finish#55907jdm merged 6 commits intoweb-platform-tests:masterfrom
jdm merged 6 commits intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Nov 6, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
changed the title
servo-wpt-sync
changed the title
servo-wpt-sync
force-pushed
the
servo_export_40455
branch
7 times, most recently
from
9fe4439 to
0549d84
Compare
servo-wpt-sync
changed the title
servo-wpt-sync
force-pushed
the
servo_export_40455
branch
from
0549d84 to
8a24223
Compare
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
- Add retry Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_40455
branch
from
8a24223 to
8e63dd1
Compare
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#40455), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Contributor
|
Could you help out here? @jdm |
Contributor
|
@yezhizhen Let me fix up the lint errors first: |
Signed-off-by: Josh Matthews <[email protected]>
Contributor
Sorry for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we always kill the instance when tests finish instead of normally shutting down. That blocked clean-ups works, such as Code Coverage we wanted to add, and other things I'm not aware of.
Testing: We have tested for a week and checked the logs of CI to confirm it works normally now.
Reviewed in servo/servo#40455