Support for testing additional accessibility properties beyond name and role.#55784
Support for testing additional accessibility properties beyond name and role.#55784zcorpan merged 26 commits intoweb-platform-tests:masterfrom
Conversation
|
There are a number of blocking details to sort out here, but I figured it was worth posting this to get things moving and get some initial feedback.
|
|
From our last meeting I think we can omit "tentative" prefixes in the API names and instead assert that the methods are only used in tentative tests. I've implemented that in this PR. |
alice
left a comment
There was a problem hiding this comment.
It's so good to see this progressing!
substantive feedback in first review has been or is being addressed.
|
(All my comments should be considered optional suggestions! I think this is fine already.) |
…accessibility_node, get_element_accessible_properties -> get_accessibility_properties_for_element, data-expected -> data-expectedproperties.
|
@cookiecrook Re-requesting review because your review is still showing as changes requested. let me know if there's anything else you would like adjusted here. Thanks. |
jonathan-j-lee
left a comment
There was a problem hiding this comment.
At @davidsgrogan's request, I've looked over the testdriver bits and they LGTM
foolip
left a comment
There was a problem hiding this comment.
I've reviewed the testdriver.js changes only.
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
|
@jcsteh is this ready to merge? |
Currently, these tests aren't passing on wpt.fyi even in Firefox because I need to get the updates landed in Firefox and then relevant updates need to reach the WPT infra. I was holding off on that until we stabilised the method names, etc., but I'll land those patches now. I think it'd be good to see this passing in Firefox at least before we land the PR in order to show that it actually works, but I'm also happy to land it sooner and file follow-ups if you think that's more effective. |
Hopefully, this triggers wpt.fyi to update the PR results so I can see whether the Firefox updates are applying correctly.
|
The tests are now passing on wpt.fyi for Firefox! I don't understand these Azure Pipelines CI failures though. It says that test_list_tests_missing_manifest is failing, but I've just spent quite some time digging through dashboards and logs and I cannot find any useful information about what the actual problem is. |
|
I asked @jgraham about this and apparently this Azure Pipelines error can be disregarded. |
|
🎉 |
get_accessibility_properties_for_accessibility_nodeandget_accessibility_properties_for_elementin wptrunner and TestDriver. For wptrunner, this is currently only supported in executormarionette (Gecko), as there is no implementation yet in any other browser to support.AriaUtils.verifyPropertiesBySelectorto test multiple properties using a JSONdata-expectedattribute on the test elements.AriaUtils.verifyAccessibilitySubtreefor simpler tree verification using a simple JS object.Closes web-platform-tests/interop-accessibility#211