fix http cache reconstruct response from cache after validation behaviour#55613
Merged
servo-wpt-sync merged 2 commits intoweb-platform-tests:masterfrom Oct 24, 2025
Merged
Conversation
wpt-pr-bot
approved these changes
Oct 23, 2025
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
ef981aa to
1ea2e69
Compare
…iour Signed-off-by: rayguo17 <[email protected]>
…red cache Signed-off-by: rayguo17 <[email protected]>
1ea2e69 to
d52d798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the scenario of constructing response from cache resources after successful validation of expired cache resouce, Instead of just copying full body of the cached_resource, check if range header exist in request, if so reuse handle_range_request function to construct response.
Testing: Should past the manual test case in Issue servo/servo#40050
Fixes: servo/servo#40050
Reviewed in servo/servo#40067