fonts: Do not apply synthetic bold if font is already bold for webfont on FreeType platform#55313
Merged
servo-wpt-sync merged 1 commit intoweb-platform-tests:masterfrom Oct 9, 2025
Conversation
wpt-pr-bot
approved these changes
Oct 8, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_39713
branch
from
9e229d2 to
50a8392
Compare
Signed-off-by: Minghua Wu <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_39713
branch
from
50a8392 to
7d1d97a
Compare
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 10, 2025
This PR follows #39519 and adds synthetic bold face support for Windows platform. Testing: There are existing WPT testcases for font synthesis (wpt/css/css-fonts/font-synthesis-*). A new test that checks for "double emboldening" (a bold font gets emboldened again) is getting added to the upstream WPT repo (web-platform-tests/wpt#55313) Depends on: servo/dwrote-rs#70, servo/dwrote-rs#71 Part of #39637 --------- Signed-off-by: Minghua Wu <[email protected]> Signed-off-by: minghuaw <[email protected]> Co-authored-by: minghuaw <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix my oversight in the previous PR #39681 where the use of OS/2 table to determine a synthetic bold face should be applied is not applied to web font.
Testing: Added a new test
tests/wpt/mozilla/tests/css/font_synthesis_weight_webfont_bold.htmlthat checks if an already-bold webfont is "double emboldened"Part of #39637
Reviewed in servo/servo#39713