renderer: Apply initial viewport scale to page_zoom.#54619
Closed
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Closed
renderer: Apply initial viewport scale to page_zoom.#54619servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
page_zoom.#54619servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Sep 1, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_39067
branch
2 times, most recently
from
af1a64d to
c8ba580
Compare
servo-wpt-sync
force-pushed
the
servo_export_39067
branch
from
c8ba580 to
5773587
Compare
Signed-off-by: Shubham Gupta <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_39067
branch
from
5773587 to
97b36eb
Compare
Collaborator
Author
|
👋 Downstream pull request (servo/servo#39067) no longer contains any upstreamable changes. Closing pull request without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attached test highlights that applying viewport scale needs reflow.
Hence applying it to
page_zoombecause we reflow forpage_zoom.Testing:
viewport/viewport-page-dimensions-after-navigation.htmlFixes: #39002
Reviewed in servo/servo#39067