Skip to content

XPath: implement lang() and id() core functions#52891

Merged
servo-wpt-sync merged 3 commits intoweb-platform-tests:masterfrom
servo:servo_export_34594
Jun 2, 2025
Merged

XPath: implement lang() and id() core functions#52891
servo-wpt-sync merged 3 commits intoweb-platform-tests:masterfrom
servo:servo_export_34594

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

@servo-wpt-sync servo-wpt-sync commented Jun 1, 2025

XPath's lang() and id() functions were still unimplemented.

Also:

  • Add WPT tests for id().
  • Fix uniqueness check in NodesetHelpers::document_order_unique.
  • Tweak the AST a bit to make it clearer to express "no predicates".
  • Fix a parsing bug where "/" was attempted before "//", leaving the "//" branch as always unused.

Reviewed in servo/servo#34594

Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_34594 branch 4 times, most recently from 68e7140 to f302dab Compare June 2, 2025 07:09
vlindhol added 3 commits June 2, 2025 08:44
Signed-off-by: Ville Lindholm <[email protected]>
Signed-off-by: Ville Lindholm <[email protected]>
Signed-off-by: Ville Lindholm <[email protected]>
@servo-wpt-sync servo-wpt-sync merged commit 1329b91 into web-platform-tests:master Jun 2, 2025
19 checks passed
@servo-wpt-sync servo-wpt-sync deleted the servo_export_34594 branch June 2, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants